LBaaS v2 l7 policy support - part 5: update l7policy #905
Conversation
lingxiankong
force-pushed
the
update-l7policy
branch
from
f1fd873
to
e79a624
Compare
|
Build failed.
|
lingxiankong
force-pushed
the
update-l7policy
branch
from
e79a624
to
e5d6406
Compare
|
Build succeeded.
|
For gophercloud#832 Neutron-LBaaS l7 policy update API implementation: https://github.com/openstack/neutron-lbaas/blob/ac720b2a49720fb99e4189f93d5a83cfb295ccb3/neutron_lbaas/services/loadbalancer/plugin.py#L931 Octavia l7 policy update API implementation: https://github.com/openstack/octavia/blob/06bf5c58d5845f684fcaf933605ed112586eefc3/octavia/api/v2/controllers/l7policy.py#L204
lingxiankong
force-pushed
the
update-l7policy
branch
from
e5d6406
to
56a0b53
Compare
|
Build succeeded.
|
|
@jtopjian @jrperritt hi, update l7 policy is ready to review :-) |
There was a problem hiding this comment.
@lingxiankong Overall this looks good. I have two questions about the fields.
| // operation. | ||
| type UpdateOpts struct { | ||
| // Name of the L7 policy. | ||
| Name string `json:"name,omitempty"` |
There was a problem hiding this comment.
Is it possible to remove a name? If so, this should be *string. That will allow a value of "" to be sent.
There was a problem hiding this comment.
That's a valid question, @jtopjian I tested in my octavia environment, an empty string for both name and description are allowed to be specified to update l7 policy, i will update the PR
| Position int32 `json:"position,omitempty"` | ||
|
|
||
| // A human-readable description for the resource. | ||
| Description string `json:"description,omitempty"` |
There was a problem hiding this comment.
Is it possible to remove a description? If so, this should be *string.
|
Build failed.
|
lingxiankong
force-pushed
the
update-l7policy
branch
from
2fcdd51
to
c509aa9
Compare
|
Build succeeded.
|
|
@jtopjian PR updated |
|
LGTM - thank you :) The example in |
For #832
Neutron-LBaaS l7 policy update API implementation:
https://github.com/openstack/neutron-lbaas/blob/ac720b2a49720fb99e4189f93d5a83cfb295ccb3/neutron_lbaas/services/loadbalancer/plugin.py#L931
Octavia l7 policy update API implementation:
https://github.com/openstack/octavia/blob/06bf5c58d5845f684fcaf933605ed112586eefc3/octavia/api/v2/controllers/l7policy.py#L204