Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capsule delete operation #956

Merged
merged 2 commits into from
May 9, 2018
Merged

Conversation

kevinzs2048
Copy link
Contributor

Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.

For #700

Depends-on: #944 #955

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2018

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2018

Build succeeded.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 77.746% when pulling e35b71c on kevin-zhaoshuai:dev-delete into c38d380 on gophercloud:master.

@coveralls
Copy link

coveralls commented Apr 22, 2018

Coverage Status

Coverage remained the same at 77.94% when pulling 3acfe7b on kevin-zhaoshuai:dev-delete into 913c7d4 on gophercloud:master.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2018

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 24, 2018

Build succeeded.

Kevin Zhao added 2 commits May 7, 2018 13:54
Change-Id: Id46a2d90e21b51f20e2f229394c8bf2666d794b8
Signed-off-by: Kevin Zhao <kevin.zhao@arm.com>
Change-Id: I744e82ccd5e5ede54fa644d742430dbc43431b4d
Signed-off-by: Kevin Zhao <kevin.zhao@arm.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 7, 2018

Build succeeded.

@kevinzs2048
Copy link
Contributor Author

@jtopjian ping for review

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtopjian jtopjian merged commit 4cb9db6 into gophercloud:master May 9, 2018
cardoe pushed a commit to cardoe/gophercloud that referenced this pull request Aug 27, 2020
…ophercloud#956)

* commit

* acl new

* before proper handle

* proper acl implementation

* update vendor

* typo fix

* add data source secret acl tests

* add container acl tests

* introduce acls import tests

* Add docs

* Proper errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants