Refactor the analysis package. #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flimzy
approved these changes
Jun 15, 2021
This doesn't make any changes to the existing logic, but makes the code a bit easier to read (or so I hope) and explains some of the logic I had to reverse-engineer in the comments. Overall this should make fixing gopherjs#603 a bit easier.
nevkontakte
force-pushed
the
issue-603-refactor
branch
from
6662441
to
4ef5aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't make any changes to the existing logic, but makes the code
a bit easier to read (or so I hope) and explains some of the logic I had
to reverse-engineer in the comments.
Overall this should make fixing
#603 a bit easier.