compiler/natives: use embed package #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The natives package has a blank import of the vfsgen package so that it stays included in go.mod (otherwise go mod tidy considers it as unused and removes it). Copy that mechanism here. Place it under a file with a "generate" build constraint so it doesn't get included in a normal gopherjs build, since it's only needed during code generation.
It's now possible to use the new embed package in the standard library to simplify the implementation of natives.FS and reduce its dependence on packages outside the standard library. This also drops support for the gopherjsdev tag where the natives could be read directly from disk without regenerating and rebuilding the gopherjs binary. That mode is less helpful now that file changes can be picked up just by rebuilding (without regenerating). It also can't be made to work reliably in module mode since module mode doesn't have the concept of a system-wide always-present workspace like GOPATH mode had. One-off occasional needs can probably be better served by temporary local code changes instead.
|
Reference app: jQuery TodoMVC (
#outputSize |
nevkontakte
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the code and GopherJS development experience slightly where possible.
(Individual commit messages provide more information.)
For #1149.