Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make runnable Examples work #590

Merged
merged 13 commits into from Feb 27, 2017
Merged

Make runnable Examples work #590

merged 13 commits into from Feb 27, 2017

Commits on Feb 27, 2017

  1. Import the official example.go

    @flimzy @dmitshur
    flimzy authored and dmitshur committed Feb 27, 2017
    Copy the full SHA
    a21effa View commit details
    Browse the repository at this point in the history

  2. Use a temp file for stdout redirection instead of a pipe

    @flimzy @dmitshur
    flimzy authored and dmitshur committed Feb 27, 2017
    Copy the full SHA
    3b6e16e View commit details
    Browse the repository at this point in the history

  3. Execute examples in CI

    @flimzy @dmitshur
    flimzy authored and dmitshur committed Feb 27, 2017
    Copy the full SHA
    061f8e7 View commit details
    Browse the repository at this point in the history

  4. Move ioutil functions inline to avoid extra import.

    @flimzy @dmitshur
    flimzy authored and dmitshur committed Feb 27, 2017
    Copy the full SHA
    f919c8f View commit details
    Browse the repository at this point in the history

  5. Don't import filepath 

    And use `js` build tag
    @flimzy @dmitshur
    flimzy authored and dmitshur committed Feb 27, 2017
    Copy the full SHA
    e4ec7a2 View commit details
    Browse the repository at this point in the history

  6. Disable two Examples not supported by GopherJS

    @flimzy @dmitshur
    flimzy authored and dmitshur committed Feb 27, 2017
    Copy the full SHA
    c44e315 View commit details
    Browse the repository at this point in the history

  7. Check io.Copy errors

    @flimzy @dmitshur
    flimzy authored and dmitshur committed Feb 27, 2017
    Copy the full SHA
    f27bcb9 View commit details
    Browse the repository at this point in the history

  8. Always remove the temp file, even in case of error

    @flimzy @dmitshur
    flimzy authored and dmitshur committed Feb 27, 2017
    Copy the full SHA
    01ef481 View commit details
    Browse the repository at this point in the history

  9. compiler/natives/src/testing: Fix build errors.

    @dmitshur
    dmitshur committed Feb 27, 2017
    Copy the full SHA
    8431197 View commit details
    Browse the repository at this point in the history

  10. compiler/natives/src: Fix package name; gofmt.

    @dmitshur
    dmitshur committed Feb 27, 2017
    Copy the full SHA
    35de0ce View commit details
    Browse the repository at this point in the history

  11. compiler/natives/src: Print expected output for disabled examples. 

    gopherjs tool testFuncs.load does not take into account the overridden
natives, see https://github.com/gopherjs/gopherjs/blob/b9bcb1da229a59cc1e1d168401662cb6450aae08/tool.go#L827.
So we still need to print the expected output for the example to pass.

Given there are only 2 disabled examples, it's easier to just do this
in short term. But it might be good to eventually improve code for
overriding natives so that examples are properly overriden as well.
    @dmitshur
    dmitshur committed Feb 27, 2017
    Copy the full SHA
    3a1ff31 View commit details
    Browse the repository at this point in the history

  12. compiler/natives/src/testing: Update comment to match behavior. 

    This version of runExample uses a temporary file rather than pipe.
Update comment to match.
    @dmitshur
    dmitshur committed Feb 27, 2017
    Copy the full SHA
    3173746 View commit details
    Browse the repository at this point in the history

  13. compiler/natives: Regenerate. 

    go generate ./...
    @dmitshur
    dmitshur committed Feb 27, 2017
    Copy the full SHA
    26efd8b View commit details
    Browse the repository at this point in the history