Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to Go 1.12.9 #939

Merged
merged 2 commits into from Sep 10, 2019
Merged

update to Go 1.12.9 #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef7d1d
CI: update to Go 1.12.9
dmitshur Sep 9, 2019
c44db05
tests: triage test failures new to Go 1.12.9
dmitshur Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion circle.yml
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ jobs:
- checkout
- run: git clone https://github.com/creationix/nvm $HOME/.nvm && cd $HOME/.nvm && git checkout v0.33.9 && echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV && echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV
- run: nvm install 10.0.0 && nvm alias default 10.0.0
- run: cd /usr/local && sudo rm -rf go && curl https://storage.googleapis.com/golang/go1.12.linux-amd64.tar.gz | sudo tar -xz
- run: cd /usr/local && sudo rm -rf go && curl https://storage.googleapis.com/golang/go1.12.9.linux-amd64.tar.gz | sudo tar -xz
- run: echo 'export PATH="$PATH:/usr/local/go/bin:$HOME/go/bin"' >> $BASH_ENV
- run: go get -t -d -v ./...
- run: go install -v
Expand Down
5 changes: 5 additions & 0 deletions tests/run.go
View file
Open in desktop
Expand Up @@ -120,6 +120,11 @@ var knownFails = map[string]failReason{
"fixedbugs/issue27201.go": {desc: "incorrect stack trace for nil dereference in inlined function"},
"fixedbugs/issue27518b.go": {desc: "sigpanic can make dead pointer live again"},
"fixedbugs/issue29190.go": {desc: "append does not fail when length overflows"},

// These are new tests in Go 1.12.9.
"fixedbugs/issue30977.go": {category: neverTerminates, desc: "does for { runtime.GC() }"},
"fixedbugs/issue32477.go": {category: notApplicable, desc: "uses runtime.SetFinalizer and runtime.GC"},
"fixedbugs/issue32680.go": {category: notApplicable, desc: "uses -gcflags=-d=ssa/check/on flag"},
}

type failCategory uint8
Expand Down