Skip to content
This repository has been archived by the owner on Apr 30, 2019. It is now read-only.

Go 1.12 / tip support #24

Closed
slimsag opened this issue Jan 20, 2019 · 1 comment
Closed

Go 1.12 / tip support #24

slimsag opened this issue Jan 20, 2019 · 1 comment

Comments

@slimsag
Copy link
Member

slimsag commented Jan 20, 2019

This package currently is not buildable on Go tip / 1.12, due to changes in the syscall/js package:

# github.com/gopherjs/gopherwasm/js
../../../../godev/pkg/mod/github.com/gopherjs/gopherwasm@v1.0.1/js/js_wasm.go:38:17: undefined: js.Callback
../../../../godev/pkg/mod/github.com/gopherjs/gopherwasm@v1.0.1/js/js_wasm.go:40:26: undefined: js.EventCallbackFlag
../../../../godev/pkg/mod/github.com/gopherjs/gopherwasm@v1.0.1/js/js_wasm.go:43:29: undefined: js.PreventDefault
../../../../godev/pkg/mod/github.com/gopherjs/gopherwasm@v1.0.1/js/js_wasm.go:44:29: undefined: js.StopPropagation
../../../../godev/pkg/mod/github.com/gopherjs/gopherwasm@v1.0.1/js/js_wasm.go:45:29: undefined: js.StopImmediatePropagation
../../../../godev/pkg/mod/github.com/gopherjs/gopherwasm@v1.0.1/js/js_wasm.go:49:9: undefined: js.NewCallback
../../../../godev/pkg/mod/github.com/gopherjs/gopherwasm@v1.0.1/js/js_wasm.go:53:9: undefined: js.NewEventCallback

If there are no objections, I may send a PR to support this under a // +build go1.12 tag.

@slimsag
Copy link
Member Author

slimsag commented Jan 20, 2019

My bad, I see that this is actually already supported it is just in the master branch and not under the v1.0.1 tag -- I'm still getting used to Go modules :)

@slimsag slimsag closed this as completed Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant