Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RenderInto (fixes #81) #180

Closed
wants to merge 17 commits into from
Closed

add RenderInto (fixes #81) #180

wants to merge 17 commits into from

Conversation

slimsag
Copy link
Member

@slimsag slimsag commented Dec 4, 2017

Based on #178, which should be reviewed first. Only the last commit here is part of this PR itself.

Fixes #81

@codecov-io
Copy link

codecov-io commented Dec 4, 2017

Codecov Report

Merging #180 into master will increase coverage by 0.35%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   47.38%   47.74%   +0.35%     
==========================================
  Files           4        4              
  Lines         650      664      +14     
==========================================
+ Hits          308      317       +9     
- Misses        301      304       +3     
- Partials       41       43       +2
Impacted Files Coverage Δ
dom.go 44.04% <57.14%> (+0.33%) ⬆️
domutil.go 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b33b65...66cb47c. Read the comment docs.

@slimsag
Copy link
Member Author

slimsag commented Dec 5, 2017

Given discussion in #179 the API here should probably not accept interface{}

@slimsag
Copy link
Member Author

slimsag commented Jan 20, 2018

Closing since I need to update this anyway.

@slimsag slimsag deleted the sg/render-into branch January 20, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants