elem: Fix lint and generate issues #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a couple regular expressions, and a couple special cases for
<audio> and <h{1-6}> now.
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 52.22% 52.22%
=======================================
Files 3 3
Lines 653 653
=======================================
Hits 341 341
Misses 258 258
Partials 54 54Continue to review full report at Codecov.
|
The first one is replaced with funName, the rest were not added back and were blank. This is a bug fix.
slimsag
reviewed
May 24, 2018
elem/elem.gen.go
Outdated
| // | ||
| // https://developer.mozilla.org/en-US/docs/Web/HTML/Element/sub | ||
| func Subscript(markup ...vecty.MarkupOrChild) *vecty.HTML { | ||
| return vecty.Tag("sub", markup...) | ||
| } | ||
|
|
||
| // Summary is used as a summary, caption, or legend for the content of a | ||
| // <details> element. | ||
| // Summary element specifies a summary, caption, or legend for a <details> |
There was a problem hiding this comment.
We'll need to fix this to remove the word element or make it a proper sentence somehow.
slimsag
reviewed
May 24, 2018
elem/elem.gen.go
Outdated
| // Template is a mechanism for holding client-side content that is not to be | ||
| // rendered when a page is loaded but may subsequently be instantiated during | ||
| // runtime using JavaScript. | ||
| // Template element is a mechanism for holding client-side content that is not |
|
aside from inline comments, I am fine with merging this. |
|
Good catch, there were several of the same type of pattern that weren't matched/corrected. The diff on the last commit seems to only get rid of the extra "element" you commented about. Yay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI currently fails on the
elempackage due to some function comments not being manipulated as needed to satisfygo vet. Also, runninggo generateon the elem package generated invalid code because of changes to the MDN website. This PR fixes those issues and touches up some MDN description irregularities.