feat: responsive navbar #22 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroidentidad
approved these changes
Jun 8, 2024
ThiagoMowszet
requested changes
Jun 8, 2024
There was a problem hiding this comment.
Hola @miquigz, muchas gracias por los cambios, esta muy bueno como quedo. Te dejo dos correciones que haria:
- Cuando el navbar supera el tamaño que ingresaste, queda descentrado el menu de opciones, te dejo una imagen para que lo veas:
Estaria bueno que siempre este centrado, sin importar el tamaño.
- Es un cambio medio tonto el que propongo, pero estaria bueno que el icono para desplegar el menu tenga un {hover: pointer}. Mas que nada por que los otros dos iconos lo tienen.
Te dejo un video tambien con estos detalles que note para que puedas verlos:
Correcciones.mp4
ThiagoMowszet
approved these changes
Jun 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.