Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cprofile on Cython code #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable cprofile on Cython code #6

wants to merge 3 commits into from

Conversation

mtreglia-gpsw
Copy link

@mtreglia-gpsw mtreglia-gpsw commented May 15, 2024 •
edited

This PR will add:

  • enable cprofile in Cython bindings
  • Add support for CYTHON_TRACE environment variable
  • Drop support python3.7 (Due to issues in the GitHub action)

@mtreglia-gpsw
vendor: Add support for CYTHON_TRACE environment variable
9816255 
This commit introduces the ability to enable line tracing in Cython for
profiling purposes. This is controlled by the CYTHON_TRACE environment variable.
When set, the 'linetrace' and 'binding' Cython directives are enabled,
and the CYTHON_TRACE macro is defined.
lbertho-gpsw
lbertho-gpsw approved these changes May 16, 2024
View reviewed changes
Copy link

@lbertho-gpsw lbertho-gpsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know well cython but it looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbertho-gpsw lbertho-gpsw lbertho-gpsw approved these changes

@mrobertseidowsky-gpsw mrobertseidowsky-gpsw Awaiting requested review from mrobertseidowsky-gpsw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mtreglia-gpsw @lbertho-gpsw