Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dockerfile): git lfs install global #56

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(Dockerfile): git lfs install global #56

merged 1 commit into from
Apr 30, 2024

Conversation

hunshcn
Copy link
Contributor

@hunshcn hunshcn commented Apr 30, 2024

fix #55

@hunshcn
fix(Dockerfile): git lfs install global
60fb921 
Signed-off-by: hunshcn <hunsh.cn@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (80087f0) to head (60fb921).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   81.43%   81.43%           
=======================================
  Files          11       11           
  Lines        1185     1185           
=======================================
  Hits          965      965           
  Misses        213      213           
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aofei
aofei approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@aofei aofei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix. Merging.

@aofei aofei merged commit 4254665 into goproxy:master Apr 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aofei aofei aofei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerfile use nobody user, but git lfs install with root
2 participants
@hunshcn @aofei