Commits on Oct 10, 2023

1. fix: mypy "type: ignore" comment errors …

   Before:
   -------
   
   ```
   (.venv)
   abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master)
   $ python -m tox -e mypy
   .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
   .pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
   .pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
   mypy: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/27/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl
   mypy: commands[0]> mypy
   src/watchdog/observers/fsevents2.py:32: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
   src/watchdog/observers/fsevents2.py:33: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
   src/watchdog/observers/fsevents.py:32: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
   tests/test_fsevents.py:19: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
   tests/test_skip_repeats_queue.py:109: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
   Found 5 errors in 4 files (checked 48 source files)
   mypy: exit 1 (0.63 seconds) /Users/abramowi/Code/OpenSource/watchdog> mypy pid=24917
   .pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
     mypy: FAIL code 1 (1.67=setup[1.04]+cmd[0.63] seconds)
     evaluation failed :( (2.49 seconds)
   ```
   
   After:
   ------
   
   ```
   (.venv)
   abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (fix-mypy-type-ignore-import-errors)
   $ python -m tox -e mypy
   .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
   .pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
   .pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
   mypy: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/28/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl
   mypy: commands[0]> mypy
   Success: no issues found in 48 source files
   .pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
     mypy: OK (1.67=setup[1.05]+cmd[0.62] seconds)
     congratulations :) (2.44 seconds)
   ```

   

   msabramo committed Oct 10, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for f434d34
   • Browse repository at this point

   Copy the full SHA

   f434d34 View commit details

   Browse the repository at this point in the history