Fix inotify full emitter to accept event_filter #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch 🥂 |
|
Ad also thank you for the docstring update, greatly appreciated. |
mraspaud
added a commit
to mraspaud/trollmoves
that referenced
this pull request
Feb 27, 2024
This is because of the bug solved in gorakhargosh/watchdog#1032
|
@BoboTiG may I ask when the next version of watchdog is to be released? Our CI fails at the moment because of this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like adding event filters in #989 somehow missed adding it to
InotifyFullEmitter. This PR fixes this.This is my first PR in this repo, feedback is welcome on how to do things up to your standards :)