win32stat: Change python2 syntax octal integers to also work with py3k #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Maybe use |
|
I personally prefer this syntax since I believe way more people can understand with a glance what int(string, base) does and I think far fewer people know the alternative 0onumber syntax. Anyhow, if you feel strongly about it I can update the PR |
|
Well, I completely disagree with that being easier. 0 is the standard notation in all languages. If you understand 0x and 0b I think it should be immediately obvious what 0o means. |
|
I updated the PR now to use the 0oxxx form. |
|
ty |
tamland
added a commit
that referenced
this pull request
Mar 16, 2014
win32stat: Change python2 syntax octal integers to also work with py3k
CCP-Aporia
pushed a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Aug 13, 2020
win32stat: Change python2 syntax octal integers to also work with py3k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.