Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed FreeBSD 10 detection issue #324

Closed
wants to merge 3 commits into from
Closed

Fixed FreeBSD 10 detection issue #324

wants to merge 3 commits into from

Conversation

simplytunde
Copy link

I looked into #312 and #320. I addressed the problem by replacing

def get_platform_name():
    if sys.platform.startswith("win"):
        return PLATFORM_WINDOWS
    elif sys.platform.startswith('darwin'):
        return PLATFORM_DARWIN
    elif sys.platform.startswith('linux'):
        return PLATFORM_LINUX
    elif sys.platform.startswith('bsd'):
        return PLATFORM_BSD
    else:
        return PLATFORM_UNKNOWN

with

def get_platform_name():
    if sys.platform.startswith("win"):
        return PLATFORM_WINDOWS
    elif sys.platform.startswith('darwin'):
        return PLATFORM_DARWIN
    elif sys.platform.startswith('linux'):
        return PLATFORM_LINUX
    elif sys.platform.startswith('bsd') or sys.platform.startswith('freebsd'):
        return PLATFORM_BSD
    else:
        return PLATFORM_UNKNOWN

Let me know what you guys think

@tamland
Copy link
Collaborator

tamland commented Jun 17, 2015

^ Exactly. Can you please only add a freebsd check. If it ain't broken..

@danilobellini
Copy link
Collaborator

Hi, I think 3 commits for a single line of change should be squashed into a single commit. Can you do that? I can do that, but this PR won't appear as "merged".

@BoboTiG
Copy link
Collaborator

BoboTiG commented Nov 13, 2018

Could you rebase your PR on the master branch too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants