Added parameter ignore_device to constructor of DirectorySnapshotDiff.
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Ajordat, Thanks for the PR 👍! Could you add docstrings and/or comments to explain what they do and why 🙏? |
|
Also, do you think you can manage to create a simple test for that? |
|
I've just added a docstring to explain it. I will create a test for it later (maybe tomorrow)! |
|
Done. Check the changes and apply them if you think they should be on the library! |
|
Thank you very much @Ajordat, perfect PR ! |
CCP-Aporia
pushed a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Aug 13, 2020
…ff (gorakhargosh#597) * Added parameter `ignore_device` to constructor of DirectorySnapshotDiff. * Fixed E704. * Added docstring. * Added test for `ignore_device` parameter on DirectorySnapshotDiff constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To compare two DirectorySnapshots the file attributes are used: A file/folder is uniquely identified using the
st_inoandst_devvalues.The problem is that st_dev may change between reboots as stated in the GNU manual. Therefore if we compare a snapshot of a previous boot with the current one, DirectorySnapshotDiff may report a file as deleted and created again even if it hasn't been touched.
This PR adds the optional parameter
ignore_deviceto the constructor of DirectorySnapshotDiff to just use the valuest_inoand ignorest_dev.