Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json tags to models #455

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

Kamandlou
Copy link
Contributor

@Kamandlou Kamandlou commented Apr 10, 2024

Closes #382

πŸ“‘ Description

Add JSON tags to models

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 71.61%. Comparing base (a1eeb28) to head (b402904).
Report is 1 commits behind head on master.

❗ Current head b402904 differs from pull request most recent head 592e9d7. Consider uploading reports for the commit 592e9d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   71.63%   71.61%   -0.02%     
==========================================
  Files         168      168              
  Lines       10175    10175              
==========================================
- Hits         7289     7287       -2     
- Misses       2323     2324       +1     
- Partials      563      564       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@Kamandlou
Copy link
Contributor Author

@hwbrzzl

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@hwbrzzl hwbrzzl enabled auto-merge (squash) April 11, 2024 08:15
@hwbrzzl hwbrzzl merged commit fb81ff9 into goravel:master Apr 11, 2024
6 checks passed
@Kamandlou Kamandlou deleted the orm-json-tags branch April 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Add json tag for orm.Model
2 participants