feat: [#410] Remove gookit/color, use pterm/pterm instead #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
==========================================
+ Coverage 70.30% 70.37% +0.06%
==========================================
Files 172 173 +1
Lines 10538 10594 +56
==========================================
+ Hits 7409 7455 +46
- Misses 2562 2572 +10
Partials 567 567 ☔ View full report in Codecov by Sentry. |
kkumar-gcc
changed the title
hwbrzzl
reviewed
May 20, 2024
support/color/color.go
Outdated
|
|
||
| func Whitep(a ...any) { white.Print(a...) } | ||
|
|
||
| func Sbluef(format string, a ...any) string { return blue.Sprintf(format, a...) } |
There was a problem hiding this comment.
How about color.Blue.Sprintf? All methods can change to this style. color.New(color.Green).Sprintf can be a basic method.
hwbrzzl
reviewed
May 20, 2024
hwbrzzl
reviewed
May 20, 2024
| color.Yellow().Println("**************************************") | ||
| color.Yellow().Println("* Application In Production! *") | ||
| color.Yellow().Printfln("**************************************") | ||
| color.Default().Println(color.Green().Sprintf("Do you really wish to run this command? (yes/no) ") + "[" + color.Green().Sprintf("no") + "]" + ":") | ||
|
|
||
| var result string | ||
| _, err := fmt.Scanln(&result) |
There was a problem hiding this comment.
Can we use ctx.Confirm directly?
There was a problem hiding this comment.
It will be fixed in next PR. (make commands support -f flag)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes goravel/goravel#410
📑 Description
✅ Checks
ℹ Additional Information