Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#398] Add a -f flag for make commands, to avoid cover the existing file by mistake #480

Merged
merged 20 commits into from
May 22, 2024

Conversation

kkumar-gcc
Copy link
Member

@kkumar-gcc kkumar-gcc commented May 21, 2024

Closes goravel/goravel#398

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@kkumar-gcc kkumar-gcc changed the title add force flag in make commands feat: [#398] Add a -f flag for make commands, to avoid cover the existing file by mistake May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 43.25581% with 122 lines in your changes are missing coverage. Please review.

Project coverage is 69.70%. Comparing base (db882c7) to head (3871235).

Files Patch % Lines
auth/console/policy_make_command.go 36.36% 7 Missing ⚠️
database/console/factory_make_command.go 30.00% 7 Missing ⚠️
database/console/model_make_command.go 30.00% 7 Missing ⚠️
database/console/observer_make_command.go 30.00% 7 Missing ⚠️
database/console/seeder_make_command.go 30.00% 7 Missing ⚠️
event/console/event_make_command.go 36.36% 7 Missing ⚠️
event/console/listener_make_command.go 36.36% 7 Missing ⚠️
foundation/console/test_make_command.go 36.36% 7 Missing ⚠️
http/console/middleware_make_command.go 36.36% 7 Missing ⚠️
http/console/request_make_command.go 36.36% 7 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   70.37%   69.70%   -0.67%     
==========================================
  Files         173      174       +1     
  Lines       10594    10721     +127     
==========================================
+ Hits         7455     7473      +18     
- Misses       2572     2681     +109     
  Partials      567      567              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@kkumar-gcc kkumar-gcc requested a review from a team May 21, 2024 06:51
foundation/console/package_make_command.go Outdated Show resolved Hide resolved
support/console/console_test.go Outdated Show resolved Hide resolved
validation/console/rule_make_command.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@kkumar-gcc kkumar-gcc merged commit bf400e0 into master May 22, 2024
6 of 8 checks passed
@kkumar-gcc kkumar-gcc deleted the kkumar-gcc/#398-fix branch May 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Add a -f flag for make commands, to avoid cover the existing file by mistake
2 participants