Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] translation support set lang path #414

Closed
1 task done
devhaozi opened this issue May 25, 2024 · 6 comments · Fixed by goravel/framework#486
Closed
1 task done

✨ [Feature] translation support set lang path #414

devhaozi opened this issue May 25, 2024 · 6 comments · Fixed by goravel/framework#486

Comments

@devhaozi
Copy link
Member

Before feedback (在反馈之前)

  • There are no features that I want to submit in Issues (当前 Issues 中没有我将要提交的新功能)

Describe Feature (描述功能)

The current value is hard-coded, it is recommended to modify it to the config item.

image

Copy link

Hi @devhaozi 👋

We think your feedback is very valuable! If you are interested, please submit a PR, please include test cases, documentation, etc., and ensure that the CI is passed, thank you and look forward to your contribution!
我们认为您的反馈非常有价值!如果有兴趣欢迎提交 PR,请包含相应的测试用例、文档等,并确保 CI 通过,感谢和期待您的贡献!

@hwbrzzl
Copy link
Contributor

hwbrzzl commented May 25, 2024

Maybe not necessary? Do you have a specific use case?

@devhaozi
Copy link
Member Author

devhaozi commented May 25, 2024

Maybe not necessary? Do you have a specific use case?

Like this, if do not run directly in the application directory, will not be able to read the translation file correctly.

image

@devhaozi
Copy link
Member Author

Maybe not necessary? Do you have a specific use case?

Like this, if do not run directly in the application directory, will not be able to read the translation file correctly.

image

Or is there any way to locate the path where the binary file is located, and then use this as a starting point to read translation file.

@devhaozi
Copy link
Member Author

I will work for this

@devhaozi devhaozi self-assigned this May 25, 2024
@devhaozi devhaozi added this to the v1.14.x milestone May 25, 2024
@hwbrzzl
Copy link
Contributor

hwbrzzl commented May 25, 2024

Makes sense for this case, we may add a configuration in config/app.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants