Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add executable path method #486

Merged
merged 18 commits into from
May 29, 2024
Merged

feat: add executable path method #486

merged 18 commits into from
May 29, 2024

Conversation

devhaozi
Copy link
Member

@devhaozi devhaozi commented May 25, 2024

Closes goravel/goravel#414

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@devhaozi
Copy link
Member Author

image

This problem looks difficult to solve. Do you have any suggestions? cc @hwbrzzl

@kkumar-gcc
Copy link
Member

kkumar-gcc commented May 25, 2024

This problem looks difficult to solve. Do you have any suggestions? cc @hwbrzzl

Directly use app.ExecutablePath() in translation's service_provider?

image

image

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 70.03%. Comparing base (91d5bcd) to head (a76d48b).

Files Patch % Lines
translation/service_provider.go 0.00% 4 Missing ⚠️
foundation/application.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   70.04%   70.03%   -0.02%     
==========================================
  Files         176      176              
  Lines       10840    10849       +9     
==========================================
+ Hits         7593     7598       +5     
- Misses       2680     2683       +3     
- Partials      567      568       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@devhaozi devhaozi self-assigned this May 25, 2024
@devhaozi devhaozi requested a review from a team May 25, 2024 11:07
@devhaozi devhaozi enabled auto-merge (squash) May 25, 2024 14:59
@devhaozi devhaozi requested a review from hwbrzzl May 25, 2024 14:59
translation/file_loader_test.go Outdated Show resolved Hide resolved
translation/file_loader_test.go Outdated Show resolved Hide resolved
translation/file_loader_test.go Outdated Show resolved Hide resolved
translation/file_loader_test.go Show resolved Hide resolved
@devhaozi devhaozi requested a review from hwbrzzl May 26, 2024 09:31
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, just a few nitpicks.

translation/file_loader_test.go Outdated Show resolved Hide resolved
translation/file_loader_test.go Show resolved Hide resolved
translation/file_loader_test.go Show resolved Hide resolved
translation/file_loader_test.go Outdated Show resolved Hide resolved
translation/file_loader_test.go Outdated Show resolved Hide resolved
translation/file_loader_test.go Outdated Show resolved Hide resolved
@devhaozi devhaozi requested review from a team and hwbrzzl May 29, 2024 09:22
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great πŸ‘

@devhaozi devhaozi merged commit 8b03f9c into master May 29, 2024
6 of 8 checks passed
@devhaozi devhaozi deleted the haozi/path branch May 29, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] translation support set lang path
3 participants