Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Feature] Change APP_HOST to APP_HOST and APP_PORT #53

Closed
hwbrzzl opened this issue Feb 25, 2023 · 2 comments · Fixed by goravel/framework#58 or #58
Closed

✨ [Feature] Change APP_HOST to APP_HOST and APP_PORT #53

hwbrzzl opened this issue Feb 25, 2023 · 2 comments · Fixed by goravel/framework#58 or #58
Assignees
@sidshrivastav
Labels
✏️ Feature

Comments

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Feb 25, 2023 •
edited
Loading

Old

APP_HOST=127.0.0.1:3000

New

APP_HOST=127.0.0.1
APP_PORT=3000
@sidshrivastav
Copy link
Contributor

hey @hwbrzzl please find the PR for this issue.

turk added a commit to turk/goravel that referenced this issue Feb 25, 2023
@turk
Change APP_HOST to APP_HOST and APP_PORT goravel#53
2e7952d
@hwbrzzl hwbrzzl linked a pull request Feb 25, 2023 that will close this issue
refactor: split APP_HOST into APP_HOST and APP_PORT #55
Closed
turk added a commit to turk/goravel that referenced this issue Feb 25, 2023
@turk
Change APP_HOST to APP_HOST and APP_PORT goravel#53
e8cdd1c
@hwbrzzl hwbrzzl linked a pull request Feb 28, 2023 that will close this issue
patch: modified the Route.Run() to use APP_PORT goravel/framework#58
Merged
@hwbrzzl hwbrzzl removed a link to a pull request Feb 28, 2023
refactor: split APP_HOST into APP_HOST and APP_PORT #55
Closed
@hwbrzzl hwbrzzl linked a pull request Feb 28, 2023 that will close this issue
refactor: split APP_HOST into APP_HOST and APP_PORT. #58
Merged
@hwbrzzl
Copy link
Contributor Author

hwbrzzl commented Feb 28, 2023

Perfect!

@hwbrzzl hwbrzzl closed this as completed Feb 28, 2023
@devhaozi devhaozi changed the title Change APP_HOST to APP_HOST and APP_PORT ✨ [Feature] Change APP_HOST to APP_HOST and APP_PORT Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sidshrivastav sidshrivastav

Labels
✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patch: modified the Route.Run() to use APP_PORT
refactor: split APP_HOST into APP_HOST and APP_PORT.
3 participants
@hwbrzzl @sidshrivastav @devhaozi