FastCGI/Config: attempt to glob for sockets if no parameters supplied #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, can you please make it work for directories as well? Because we, for example, have our socket within |
|
Sure, I can send a new PR or update this one, but since this is open for a half a year already - I don't know if owner is looking forward to this kind of changes. |
szepeviktor
reviewed
Dec 15, 2016
| $host = '/var/run/php5-fpm.sock'; | ||
| $socket = current(glob('/var/run/php*.sock')); | ||
| if (!empty($socket)) { | ||
| $host = $socket; |
There was a problem hiding this comment.
There could be many sockets, please say $socket[0]
Sorry! current()
|
Implemented in #49. closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers #17
It alters the current behaviour, though (might be seen as a BC).
For simplicity, I've altered the logic in following way: if user didn't specify
--fcgioption - cachetool shall try to find unix socket first, and in case no socket is found - it shall fallback to TCP.Perhaps this behaviour should be documented?