Refactor function

gordalina · Jul 20, 2020 · 51f95cf · 51f95cf
1 parent 27e2d82
commit 51f95cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/hush_provider.ex b/lib/hush_provider.ex
@@ -37,12 +37,10 @@ defmodule Hush.Provider.GcpSecretManager do
   end
 
   defp project(config \\ nil) do
-    cond do
-      config == nil ->
-        Application.get_env(:hush_gcp_secret_manager, :project_id, nil)
-
-      true ->
-        config[:hush_gcp_secret_manager] |> Keyword.get(:project_id, nil)
+    if config == nil do
+      Application.get_env(:hush_gcp_secret_manager, :project_id, nil)
+    else
+      config[:hush_gcp_secret_manager] |> Keyword.get(:project_id, nil)
     end
   end
 

diff --git a/test/hush_provider_test.exs b/test/hush_provider_test.exs
@@ -25,7 +25,9 @@ defmodule Hush.Provider.GcpSecretManagerTest do
 
     test "with config" do
       assert nil == Application.get_env(:hush_gcp_secret_manager, :project_id)
-      assert :ok == GcpSecretManager.load([{:hush_gcp_secret_manager, [project_id: "project_id"]}])
+
+      assert :ok ==
+               GcpSecretManager.load([{:hush_gcp_secret_manager, [project_id: "project_id"]}])
     end
   end