Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change structs back to classes #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nomad1
Copy link

@Nomad1 Nomad1 commented Oct 6, 2015

This code was ported from Java and some parts still have
Java-styled functions that modify one or more class properties without
having ’out’ or ‘ref’ keywords on parameter list, breaking the logic
when classes are defined as value type instead of reference type as in
java. I changed these classes back to class from struct fixing those
issues and making sure that engine works as expected. That makes
particle simulation work as expected but that is not 100% correct way
to do this.

This code was ported from Java and some functions still have
Java-styled functions that modify one or more class properties without
having ’out’ or ‘ref’ keywords on parameter list, breaking the logic
when classes are defined as value type instead of reference type as in
java. I changed these classes back to class from struct fixing those
issues and making sure that engine works as expected. That makes
particle simulation work as expected but that is not 100% correct way
to do this.
@Nomad1 Nomad1 changed the title Changed structs back to classes Change structs back to classes Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant