Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlineMode in modalView state #195

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Alelenka
Copy link

Issue

There is a need to use inlineMode with ViewCntroller sheet presented modaly, and not like a childViewController.

Result

So now inlineMode can be possible as in documentation

sheetController.animateIn(to: view, in: self)

And also we can use

self.present(sheet, animated: false, completion: nil)

Solution

all gestures would be sent to presentingViewController.view if it exists

Additional fix

If we use inlineMode with sheetController.animateIn inside TabBarController we would want to consider safeArea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant