Add warnings for unsupported ODBC functions

gordthompson · Aug 29, 2020 · ba8e317 · ba8e317
1 parent d11dbde
commit ba8e317
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 2 deletions.
diff --git a/_pypi_test_upload.bat b/_pypi_test_upload.bat
diff --git a/sqlalchemy_access/__init__.py b/sqlalchemy_access/__init__.py
@@ -20,7 +20,7 @@
 
 import pyodbc
 
-__version__ = "1.0.7b1"
+__version__ = "1.0.7"
 
 pyodbc.pooling = False  # required for Access databases with ODBC linked tables
 _registry.register(

diff --git a/sqlalchemy_access/base.py b/sqlalchemy_access/base.py
@@ -11,6 +11,8 @@
 
 
 """
+import warnings
+
 from sqlalchemy import types, exc, pool
 from sqlalchemy.sql import compiler
 from sqlalchemy.engine import default, reflection
@@ -724,6 +726,14 @@ def get_pk_constraint(self, connection, table_name, schema=None, **kw):
         except pyodbc.InterfaceError as ie:
             if ie.args[0] == "IM001":
                 # ('IM001', '[IM001] [Microsoft][ODBC Driver Manager] Driver does not support this function (0) (SQLPrimaryKeys)')
+                warnings.warn(
+                    (
+                        'The Access ODBC driver does not support the ODBC "SQLPrimaryKeys" function. '
+                        "get_pk_constraint() is returning an empty list."
+                    ),
+                    exc.SAWarning,
+                    stacklevel=3,
+                )
                 return []
             else:
                 raise
@@ -738,6 +748,14 @@ def get_foreign_keys(self, connection, table_name, schema=None, **kw):
         except pyodbc.InterfaceError as ie:
             if ie.args[0] == "IM001":
                 # ('IM001', '[IM001] [Microsoft][ODBC Driver Manager] Driver does not support this function (0) (SQLForeignKeys)')
+                warnings.warn(
+                    (
+                        'The Access ODBC driver does not support the ODBC "SQLForeignKeys" function. '
+                        "get_foreign_keys() is returning an empty list."
+                    ),
+                    exc.SAWarning,
+                    stacklevel=3,
+                )
                 return []
             else:
                 raise

diff --git a/test/test_suite.py b/test/test_suite.py
@@ -6,6 +6,7 @@
     ComponentReflectionTest as _ComponentReflectionTest,
 )
 from sqlalchemy.testing.suite import DateTimeTest as _DateTimeTest
+from sqlalchemy.testing.suite import ExistsTest as _ExistsTest
 from sqlalchemy.testing.suite import (
     ExpandingBoundInTest as _ExpandingBoundInTest,
 )
@@ -55,6 +56,20 @@ def test_null_bound_comparison(cls):
         return
 
 
+class ExistsTest(_ExistsTest):
+    @pytest.mark.skip()
+    def test_select_exists(cls):
+        # bypass this test because Access ODBC fails with
+        # "SELECT statement includes a reserved word or an argument name ..."
+        return
+
+    @pytest.mark.skip()
+    def test_select_exists_false(cls):
+        # bypass this test because Access ODBC fails with
+        # "SELECT statement includes a reserved word or an argument name ..."
+        return
+
+
 class ExpandingBoundInTest(_ExpandingBoundInTest):
     @pytest.mark.skip()
     def test_null_in_empty_set_is_false(cls):