feat: replacing afero.Fs with fs.FS

[caarlos0]

BREAKING CHANGE: stop using afero.Fs and use the new fs.FS package instead.

Also improves windows support all over the place.

[caarlos0]

Not to be merged before go 1.16 stable is out...

[caarlos0]

setup-go action don't support go tip 😞

[caarlos0]

I'm not entirely sure about this part yet... DirFS won't allow to start on /, so to keep the API I'm doing this little hack here... but maybe we can just declare it a breaking change?

[erikgeiser]

What do you mean by that? prefix = stringSeparator and WithFS(os.DirFS(prefix)) seems like you are doing exactly that.

As far as I understand the docs, os.DirFS has no concept of a current working directy. So normally I would expect the fs to be os.DirFS("/") so I can access everything. But if I open file I would expect it to open /cwd/file where /cwd is my current working directory. But instead, os.DirFS("/") opens /file`. So what we would need to keep track of is the current working directory right?

[caarlos0]

fs.Open only accepts relative dirs

but I think this is indeed outside of the API.

Before it was also only working on paths relative to current, and didn't accept absolute paths anyway (/etc/foo/bar.conf for example)

[codecov]

Codecov Report

Merging #17 (225313c) into main (71ebeed) will decrease coverage by 0.76%.
The diff coverage is 88.57%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   83.67%   82.90%   -0.77%     
==========================================
  Files           2        2              
  Lines          98      117      +19     
==========================================
+ Hits           82       97      +15     
- Misses          9       12       +3     
- Partials        7        8       +1     

Impacted Files	Coverage Δ
glob.go	82.27% <88.57%> (-1.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ebeed...225313c. Read the comment docs.

[caarlos0]

@erikgeiser I think its good to be reviewed again.

I make the Root path stuff an Option (and also added a "print options" option, for debugging et al).

Basically, by default, we start in current working dir (.) (as before). If the API user wants, they can use the MaybeRootFS option to detect that and work accordingly.

Prefix is needed in the case of "RootFS" because all results will be relative to the FS (in this case, /), so the results will be etc/foo.conf instead of /etc/foo.conf, for example, which may cause confusion.

[caarlos0]

at the cost of my sanity, it is now working on windows