Issue #52 delete src directory before untarring to prevent masking er…

…rors

samples/godownloader-event-gateway.sh

@@ -43,13 +43,12 @@ parse_args() {
 # out preventing half-done work
 execute() {
   tmpdir=$(mktmpdir)
-  log_debug "will download files to ${tmpdir}"
+  log_debug "downloading files into ${tmpdir}"
   http_download "${tmpdir}/${TARBALL}" "${TARBALL_URL}"
   http_download "${tmpdir}/${CHECKSUM}" "${CHECKSUM_URL}"
   hash_sha256_verify "${tmpdir}/${TARBALL}" "${tmpdir}/${CHECKSUM}"
-
-  (cd "${tmpdir}" && untar "${TARBALL}")
   srcdir="${tmpdir}"
+  (cd "${tmpdir}" && untar "${TARBALL}")
   install -d "${BINDIR}"
   for binexe in "event-gateway" ; do
     if [ "$OS" = "windows" ]; then

samples/godownloader-gometalinter.sh

@@ -43,13 +43,13 @@ parse_args() {
 # out preventing half-done work
 execute() {
   tmpdir=$(mktmpdir)
-  log_debug "will download files to ${tmpdir}"
+  log_debug "downloading files into ${tmpdir}"
   http_download "${tmpdir}/${TARBALL}" "${TARBALL_URL}"
   http_download "${tmpdir}/${CHECKSUM}" "${CHECKSUM_URL}"
   hash_sha256_verify "${tmpdir}/${TARBALL}" "${tmpdir}/${CHECKSUM}"
-
-  (cd "${tmpdir}" && untar "${TARBALL}")
   srcdir="${tmpdir}/${NAME}"
+  rm -rf "${srcdir}"
+  (cd "${tmpdir}" && untar "${TARBALL}")
   install -d "${BINDIR}"
   for binexe in "gometalinter" "gocyclo" "nakedret" "misspell" "govet" "gas" "golint" "ineffassign" "goconst" "errcheck" "maligned" "unconvert" "dupl" "structcheck" "varcheck" "safesql" "deadcode" "lll" "goimports" "gotype" "gosimple" "megacheck" "staticcheck" "unused" "interfacer" "unparam" ; do
     if [ "$OS" = "windows" ]; then

samples/godownloader-goreleaser.sh

@@ -43,13 +43,12 @@ parse_args() {
 # out preventing half-done work
 execute() {
   tmpdir=$(mktmpdir)
-  log_debug "will download files to ${tmpdir}"
+  log_debug "downloading files into ${tmpdir}"
   http_download "${tmpdir}/${TARBALL}" "${TARBALL_URL}"
   http_download "${tmpdir}/${CHECKSUM}" "${CHECKSUM_URL}"
   hash_sha256_verify "${tmpdir}/${TARBALL}" "${tmpdir}/${CHECKSUM}"
-
-  (cd "${tmpdir}" && untar "${TARBALL}")
   srcdir="${tmpdir}"
+  (cd "${tmpdir}" && untar "${TARBALL}")
   install -d "${BINDIR}"
   for binexe in "goreleaser" ; do
     if [ "$OS" = "windows" ]; then

samples/godownloader-hugo.sh

@@ -43,13 +43,12 @@ parse_args() {
 # out preventing half-done work
 execute() {
   tmpdir=$(mktmpdir)
-  log_debug "will download files to ${tmpdir}"
+  log_debug "downloading files into ${tmpdir}"
   http_download "${tmpdir}/${TARBALL}" "${TARBALL_URL}"
   http_download "${tmpdir}/${CHECKSUM}" "${CHECKSUM_URL}"
   hash_sha256_verify "${tmpdir}/${TARBALL}" "${tmpdir}/${CHECKSUM}"
-
-  (cd "${tmpdir}" && untar "${TARBALL}")
   srcdir="${tmpdir}"
+  (cd "${tmpdir}" && untar "${TARBALL}")
   install -d "${BINDIR}"
   for binexe in "hugo" ; do
     if [ "$OS" = "windows" ]; then

samples/godownloader-minify.sh

@@ -43,13 +43,12 @@ parse_args() {
 # out preventing half-done work
 execute() {
   tmpdir=$(mktmpdir)
-  log_debug "will download files to ${tmpdir}"
+  log_debug "downloading files into ${tmpdir}"
   http_download "${tmpdir}/${TARBALL}" "${TARBALL_URL}"
   http_download "${tmpdir}/${CHECKSUM}" "${CHECKSUM_URL}"
   hash_sha256_verify "${tmpdir}/${TARBALL}" "${tmpdir}/${CHECKSUM}"
-
-  (cd "${tmpdir}" && untar "${TARBALL}")
   srcdir="${tmpdir}"
+  (cd "${tmpdir}" && untar "${TARBALL}")
   install -d "${BINDIR}"
   for binexe in "minify" ; do
     if [ "$OS" = "windows" ]; then

samples/godownloader-misspell.sh

@@ -43,13 +43,12 @@ parse_args() {
 # out preventing half-done work
 execute() {
   tmpdir=$(mktmpdir)
-  log_debug "will download files to ${tmpdir}"
+  log_debug "downloading files into ${tmpdir}"
   http_download "${tmpdir}/${TARBALL}" "${TARBALL_URL}"
   http_download "${tmpdir}/${CHECKSUM}" "${CHECKSUM_URL}"
   hash_sha256_verify "${tmpdir}/${TARBALL}" "${tmpdir}/${CHECKSUM}"
-
-  (cd "${tmpdir}" && untar "${TARBALL}")
   srcdir="${tmpdir}"
+  (cd "${tmpdir}" && untar "${TARBALL}")
   install -d "${BINDIR}"
   for binexe in "misspell" ; do
     if [ "$OS" = "windows" ]; then

shell_godownloader.go

@@ -74,13 +74,13 @@ execute() {
   http_download "${tmpdir}/${TARBALL}" "${TARBALL_URL}"
   http_download "${tmpdir}/${CHECKSUM}" "${CHECKSUM_URL}"
   hash_sha256_verify "${tmpdir}/${TARBALL}" "${tmpdir}/${CHECKSUM}"
-
-  (cd "${tmpdir}" && untar "${TARBALL}")
   {{- if .Archive.WrapInDirectory }}
   srcdir="${tmpdir}/${NAME}"
+  rm -rf "${srcdir}"
   {{- else }}
   srcdir="${tmpdir}"
   {{- end }}
+  (cd "${tmpdir}" && untar "${TARBALL}")
   install -d "${BINDIR}"
   for binexe in {{ range .Builds }}"{{ .Binary }}" {{ end }}; do
     if [ "$OS" = "windows" ]; then