-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supprt tags in sub ref directory? #380
Comments
this whole thing should probably be removed, probably, as goreleaser itself already handles it cc/ @crazy-max |
Thank you for your quick response. IMO #370 is not enough. There is also a check like Lines 31 to 33 in b508e2e
Then, Lines 49 to 53 in b508e2e
|
hmm, indeed... @crazy-max probably we should remove those and bump the action to v4... |
Hum I see yeah we might need a major bump. |
should be fixed in #370 |
But the bug is in Lines 19 to 24 in b508e2e
? It will return an incorrect tag to |
ah sorry, the dirty thing is still there. |
#382 should fix it by removing it entirely. |
The code says:
goreleaser-action/src/git.ts
Lines 19 to 24 in b508e2e
If
GITHUB_REF=refs/tags/release/0.1.0
, then thetag
will be0.1.0
, but it should berelease/0.1.0
Is the
pop
done by purpose? Could it supportrelease/0.1.0
and use0.1.0
as the version?The text was updated successfully, but these errors were encountered: