Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit messages limited to the last commit #56

Closed
deimosfr opened this issue Dec 24, 2019 · 3 comments
Closed

Commit messages limited to the last commit #56

deimosfr opened this issue Dec 24, 2019 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@deimosfr
Copy link

Hi,

I'd like to have the full changelog in the Github release between versions. When I run goreleaser with action, there is only the last one, however when I'm running it locally, it works as it should. Are this limitations due to Action?

Do you have any suggestions?

Thanks

@crazy-max
Copy link
Member

Hi @deimosfr,

Can you post your workflow here please and/or link to your repo?

Thanks

@deimosfr
Copy link
Author

deimosfr commented Dec 24, 2019

Sure,

Here is the workflow:

name: goreleaser

on:
  create:
    tags:

jobs:
  qovery:
    runs-on: ubuntu-latest
    steps:
      -
        name: Checkout
        uses: actions/checkout@master
      -
        name: Set up Go
        uses: actions/setup-go@master
        with:
          go-version: 1.13.x
      -
        name: Run GoReleaser
        uses: goreleaser/goreleaser-action@v1
        with:
          version: latest
          args: release --rm-dist
        env:
          GITHUB_TOKEN: ${{ secrets.GORELEASER_GITHUB_TOKEN }}

And link to the release page (and repo): https://github.com/Qovery/qovery-cli/releases

GitHub
Qovery Command Line Interface. Contribute to Qovery/qovery-cli development by creating an account on GitHub.

@crazy-max
Copy link
Member

@deimosfr The issue is here:

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +6019d6008095531b57054b1a856b71df58bc8e5e:refs/tags/v0.1

You are using actions/checkout@master which is based on version 2 and the default behavior now fetches only the commit being checked-out as explained in their changelog.

To summarize, you should only use tag names or commit ID when using actions, this will prevent you from having regressions in your workflow. I will update our example in the README.

To fix this on your side, two possibilities:

-
  name: Checkout
  uses: actions/checkout@v1

or

-
  name: Checkout
  uses: actions/checkout@v2
  with:
    fetch-depth: 0

@crazy-max crazy-max added the documentation Improvements or additions to documentation label Dec 24, 2019
crazy-max added a commit that referenced this issue Dec 24, 2019
zmwangx added a commit to zmwangx/ets that referenced this issue Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants