Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support downloading goreleaser pro #284

Merged
merged 13 commits into from
May 27, 2021
Merged

feat: support downloading goreleaser pro #284

merged 13 commits into from
May 27, 2021

Conversation

caarlos0
Copy link
Member

:)

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #284 (8b3d02c) into master (8571fa9) will decrease coverage by 0.10%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   86.51%   86.40%   -0.11%     
==========================================
  Files           4        5       +1     
  Lines          89      103      +14     
  Branches       16       18       +2     
==========================================
+ Hits           77       89      +12     
  Misses          6        6              
- Partials        6        8       +2     
Impacted Files Coverage Δ
src/pro.ts 75.00% <75.00%> (ø)
src/github.ts 86.66% <87.50%> (+0.30%) ⬆️
src/installer.ts 94.28% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8571fa9...8b3d02c. Read the comment docs.

@crazy-max
Copy link
Member

crazy-max commented May 27, 2021

@caarlos0 Maybe GORELEASER_KEY should be enough to download the right dist binary? This way we could remove the distribution input WDYT? If you want to add in the future an "enterprise" distribution maybe you could add a prefix to your GORELEASER_KEY we could use to also identify the right dist like:

  • GORELEASER_KEY=pro-a1cf8462-6364-48b2-aa6d-1026f5a211da => https://goreleaser.com/static/releases-pro.json
  • GORELEASER_KEY=ent-27596c99-7ad8-41a2-b842-7d8898544f70 => https://goreleaser.com/static/releases-ent.json
  • GORELEASER_KEY= => https://goreleaser.com/static/releases.json

WDYT?

@caarlos0
Copy link
Member Author

hmm, yeah, that makes sense... let me try and change it :)

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
This reverts commit b3dd052.
This reverts commit a9d7d30.
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0
Copy link
Member Author

actually, the user might pass --key instead of the env, so its better leave as-is IMHO...

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@caarlos0 caarlos0 merged commit 70eb4e5 into master May 27, 2021
@caarlos0 caarlos0 deleted the bec-89 branch May 27, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants