fix: race condition on artifacts.List (#3813)

I have no idea why this never happened before... the lock was
ineffective in `artifacts.List`, which should have caused at least some
race condition at some point.

Anyway, got it once locally while working on another feature, and
couldn't believe my eyes.

Fixed, thank goodness!

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

internal/artifact/artifact.go

@@ -278,22 +278,22 @@ type Artifacts struct {
 }
 
 // New return a new list of artifacts.
-func New() Artifacts {
-	return Artifacts{
+func New() *Artifacts {
+	return &Artifacts{
 		items: []*Artifact{},
 		lock:  &sync.Mutex{},
 	}
 }
 
 // List return the actual list of artifacts.
-func (artifacts Artifacts) List() []*Artifact {
+func (artifacts *Artifacts) List() []*Artifact {
 	artifacts.lock.Lock()
 	defer artifacts.lock.Unlock()
 	return artifacts.items
 }
 
 // GroupByID groups the artifacts by their ID.
-func (artifacts Artifacts) GroupByID() map[string][]*Artifact {
+func (artifacts *Artifacts) GroupByID() map[string][]*Artifact {
 	result := map[string][]*Artifact{}
 	for _, a := range artifacts.List() {
 		id := a.ID()
@@ -306,7 +306,7 @@ func (artifacts Artifacts) GroupByID() map[string][]*Artifact {
 }
 
 // GroupByPlatform groups the artifacts by their platform.
-func (artifacts Artifacts) GroupByPlatform() map[string][]*Artifact {
+func (artifacts *Artifacts) GroupByPlatform() map[string][]*Artifact {
 	result := map[string][]*Artifact{}
 	for _, a := range artifacts.List() {
 		plat := a.Goos + a.Goarch + a.Goarm + a.Gomips + a.Goamd64
@@ -442,7 +442,7 @@ func ByExt(exts ...string) Filter {
 // deduplicating artifacts by path (preferring UploadableBinary over all others). Note: this filter is unique in the
 // sense that it cannot act in isolation of the state of other artifacts; the filter requires the whole list of
 // artifacts in advance to perform deduplication.
-func ByBinaryLikeArtifacts(arts Artifacts) Filter {
+func ByBinaryLikeArtifacts(arts *Artifacts) Filter {
 	// find all of the paths for any uploadable binary artifacts
 	uploadableBins := arts.Filter(ByType(UploadableBinary)).List()
 	uploadableBinPaths := map[string]struct{}{}
@@ -500,9 +500,9 @@ func And(filters ...Filter) Filter {
 // There are some pre-defined filters but anything of the Type Filter
 // is accepted.
 // You can compose filters by using the And and Or filters.
-func (artifacts *Artifacts) Filter(filter Filter) Artifacts {
+func (artifacts *Artifacts) Filter(filter Filter) *Artifacts {
 	if filter == nil {
-		return *artifacts
+		return artifacts
 	}
 
 	result := New()
@@ -515,7 +515,7 @@ func (artifacts *Artifacts) Filter(filter Filter) Artifacts {
 }
 
 // Paths returns the artifact.Path of the current artifact list.
-func (artifacts Artifacts) Paths() []string {
+func (artifacts *Artifacts) Paths() []string {
 	var result []string
 	for _, artifact := range artifacts.List() {
 		result = append(result, artifact.Path)
@@ -527,7 +527,7 @@ func (artifacts Artifacts) Paths() []string {
 type VisitFn func(a *Artifact) error
 
 // Visit executes the given function for each artifact in the list.
-func (artifacts Artifacts) Visit(fn VisitFn) error {
+func (artifacts *Artifacts) Visit(fn VisitFn) error {
 	for _, artifact := range artifacts.List() {
 		if err := fn(artifact); err != nil {
 			return err

internal/exec/exec.go

@@ -109,7 +109,7 @@ func executeCommand(c *command, artifact *artifact.Artifact) error {
 	return nil
 }
 
-func filterArtifacts(artifacts artifact.Artifacts, publisher config.Publisher) []*artifact.Artifact {
+func filterArtifacts(artifacts *artifact.Artifacts, publisher config.Publisher) []*artifact.Artifact {
 	filters := []artifact.Filter{
 		artifact.ByType(artifact.UploadableArchive),
 		artifact.ByType(artifact.UploadableFile),

pkg/context/context.go

@@ -78,7 +78,7 @@ type Context struct {
 	TokenType          TokenType
 	Git                GitInfo
 	Date               time.Time
-	Artifacts          artifact.Artifacts
+	Artifacts          *artifact.Artifacts
 	ReleaseURL         string
 	ReleaseNotes       string
 	ReleaseNotesFile   string