fix: add dir headers to zip files

goreleaser · Apr 13, 2023 · 4a98220 · 4a98220
1 parent ec7c15d
commit 4a98220
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/pkg/archive/zip/zip.go b/pkg/archive/zip/zip.go
@@ -44,9 +44,7 @@ func Copying(source *os.File, target io.Writer) (Archive, error) {
 	}
 	w := New(target)
 	for _, zf := range r.File {
-		if zf.Mode().IsDir() {
-			continue
-		}
+
 		w.files[zf.Name] = true
 		hdr := zip.FileHeader{
 			Name:               zf.Name,
@@ -59,6 +57,9 @@ func Copying(source *os.File, target io.Writer) (Archive, error) {
 		if err != nil {
 			return Archive{}, fmt.Errorf("creating %q header in target: %w", zf.Name, err)
 		}
+		if zf.Mode().IsDir() {
+			continue
+		}
 		rr, err := zf.Open()
 		if err != nil {
 			return Archive{}, fmt.Errorf("opening %q from source: %w", zf.Name, err)

diff --git a/pkg/archive/zip/zip_test.go b/pkg/archive/zip/zip_test.go
@@ -159,3 +159,5 @@ func TestTarInvalidLink(t *testing.T) {
 		Destination: "badlink.txt",
 	}))
 }
+
+// TODO: add copying test