Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templateable NFPMs signatures #2419

Closed
nicocha30 opened this issue Aug 23, 2021 · 1 comment · Fixed by #2448
Closed

Templateable NFPMs signatures #2419

nicocha30 opened this issue Aug 23, 2021 · 1 comment · Fixed by #2448
Assignees
@caarlos0
Labels
enhancement New feature or request
Projects
Board

Comments

@nicocha30
Copy link

Is your feature request related to a problem? Please describe.

NFPM signatures are not templateable. This could be useful when running CI like GitLab using "Variable Files" (https://docs.gitlab.com/ee/ci/variables/#cicd-variable-types).

Describe the solution you'd like

Allow templateable signatures:

    rpm:
      signature:
        key_file: "{{ .Env.CI_SIGNING_KEY }}"
    deb:
      signature:
        key_file: "{{ .Env.CI_SIGNING_KEY }}"

Thanks,

Nicolas
@nicocha30 nicocha30 added the enhancement New feature or request label Aug 23, 2021
@caarlos0 caarlos0 added this to New issues in Board via automation Aug 23, 2021
@caarlos0 caarlos0 moved this from New issues to To do in Board Aug 23, 2021
@caarlos0 caarlos0 self-assigned this Sep 1, 2021
@caarlos0 caarlos0 moved this from To do to In progress in Board Sep 1, 2021
caarlos0 added a commit that referenced this issue Sep 1, 2021
@caarlos0
feat: templateable nfpm key files
2d5565e 
closes #2419

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 mentioned this issue Sep 1, 2021
Merged
@caarlos0
Copy link
Member

caarlos0 commented Sep 1, 2021

see #2448

Board automation moved this from In progress to Done Sep 1, 2021
caarlos0 added a commit that referenced this issue Sep 1, 2021
@caarlos0
feat: templateable nfpm key files (#2448)
b63e544 
closes #2419

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request
Projects
No open projects
Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: templateable nfpm key files goreleaser/goreleaser
2 participants
@caarlos0 @nicocha30