Universal binaries clash between multiple ids when using the same name_template

[lowdewijk]

What happened?

I have a config that specifies two different builds of the same binary (one with full capabilities and one with limited capabiities). When I use universal_binaries with two different ids, referencing the two different build ids, but with the same name_template the file paths clash. The result is that one binary overwrites the other and that I get two archives with the same build in it (the one that was specified last).

E.g.:

universal_binaries:
-
  id: my-cli-full
  ids:
  - my-cli-full
  name_template: 'cli'
  replace: true
-
  id: my-cli-limited
  ids:
  - my-cli-limited
  name_template: 'cli'
  replace: true

Will result in two universal binary artifacts, one named full and one named limited, with both only the limited binary in it. You can see why this is happening in the output of goreleaser:

   • universal binaries
      • creating from 2 binaries  binary=dist/cli_darwin_all/cli
      • creating from 2 binaries  binary=dist/cli_darwin_all/cli

How can we reproduce this?

Take any two builds and create two respective universal binary ids for them. Then give them the same name_template.

goreleaser version

1.8.3

GoReleaser Check

• goreleaser check shows no errors

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

I've narrowed this down to:

https://github.com/goreleaser/goreleaser/blob/02595554de30243792f4ec803338258e23bf5702/internal/pipe/universalbinary/universalbinary.go

Line 143 says: path := filepath.Join(ctx.Config.Dist, name+"_darwin_all", name)

I believe it should say path := filepath.Join(ctx.Config.Dist, unibin.Id +"_darwin_all", name)

[caarlos0]

it is this way to mimic the builds, which do the same thing.

maybe this should change, though:

• use the id instead of the name, on both builds and universal binaries
• the build id should probably default to the binary name to keep previous behavior

I'll look into it, thanks for reporting

[lowdewijk]

Thank you 👍

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.