Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser can't update existing draft release #3072

Closed
3 tasks done
yihuang opened this issue Apr 28, 2022 · 1 comment · Fixed by #3073
Closed
3 tasks done

goreleaser can't update existing draft release #3072

yihuang opened this issue Apr 28, 2022 · 1 comment · Fixed by #3073
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yihuang
Copy link
Contributor

yihuang commented Apr 28, 2022

What happened?

When there's an existing draft release, gorelease won't update it, but create a new one.

https://docs.github.com/en/rest/releases/releases#get-a-release-by-tag-name
Because the api goreleaser use right now don't return draft release.
To find a exiting draft release, one need to iterate all the releases like this: https://github.com/softprops/action-gh-release/blob/fe9a9bd3295828558c7a3c004f23f3bf77d155b2/src/github.ts#L205

How can we reproduce this?

Configure a goreleaser with draft: true, create a draft release first before trigger goreleaser in github action, after it finish, it'll create a duplicated draft release.

goreleaser version

`ghcr.io/goreleaser/goreleaser-cross:v1.17.9`

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@yihuang yihuang added bug Something isn't working triage Issue pending triage by one of the maintainers labels Apr 28, 2022
yihuang added a commit to yihuang/goreleaser that referenced this issue Apr 28, 2022
@caarlos0 caarlos0 added this to the v1.9.0 milestone Apr 28, 2022
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Apr 28, 2022
caarlos0 pushed a commit that referenced this issue May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants