nfpm extensions not being set

[mbamber]

What happened?

When trying to upload artifacts to Artifactory with an exts filter, the artifacts generated by nfpm are not being selected as the docs might suggest:

    # File extensions to filter for.
    # This might be useful if you have multiple packages with different
    # extensions with the same ID, and need to upload each extension to
    # a different place (e.g. nFPM packages).
    #
    # Since: v1.7
    exts:
    - deb
    - rpm

How can we reproduce this?

Example config snippet

...
nfpms:
  -
    description: My package
    formats:
      - deb
...
artifactories:
  -
    name: default
    exts:
      - .deb
...

goreleaser version

goreleaser version dev
goos: darwin
goarch: amd64
module version: v1.16.2, checksum: h1:usMTxv8JXDNUUmVo0VSTExYBwCmLOuqa1l6hkmE/diA=

https://goreleaser.com

GoReleaser Check

• goreleaser check shows no errors

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

After a quick look at the source, I believe this an issue with the filtering. In particular, I think the Ext extra property isn't being set for artifacts generated by nfpm:

goreleaser/internal/pipe/nfpm/nfpm.go

Line 442 in b36e30a

Extra: map[string]interface{}{

The attribute is set correctly for artifacts built directly:

goreleaser/internal/builders/golang/build.go

Line 149 in b36e30a

artifact.ExtraExt: options.Ext,

[caarlos0]

ah yeah, your assessment is right... not sure if it got broken after some merge or what, but I think it was there at some point...

Anyway, thanks for reporting, will fix soon.

[mbamber]

See #3940 which I think should fix this

[caarlos0]

Thank you @mbamber !

[Romain-Geissler-1A]

Hi,

I spend some time trying to understand why my uploading task didn't work, and found it's related to exts and finally found this ;) It seems the latest fix isn't released, do you know when you will cut the next release ?

Cheers,
Romain

[caarlos0]

Hey, probably next week, or earlier next month

[mbamber]

I thought this was already out? I'm sure I'm using it 😅

See https://github.com/goreleaser/goreleaser/releases/tag/v1.17.1

[Romain-Geissler-1A]

Ah, I have wrongly checked the history, thanks !