-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linkedin: could not get profile id: could not find 'id' in result
#4421
Comments
hmm, maybe linkedin changed their API 🤔 cc/ @Dentrax |
For what it's worth, I tried to hit the |
It looks like that you need one of the following scopes to hit Permission | Description https://learn.microsoft.com/en-us/linkedin/shared/integrations/people/profile-api#permissions |
@gabrielcipriano any idea how to get any of these permissions? The dashboard for adding permissions doesn't allow manually adding them (as far as I can see) and you need to do it through the process of adding "Products" to your app, which then add relevant scopes (although this is quite opaque, it doesn't say which scopes will be added for each Product). It looks like they've made it more difficult to request scopes. |
hey @stefanlogue, I found this discussion and @caarlos0 is right, they changed their api. They deprecated
I will open a PR with the needed changes. |
Closes #4421 I chose to keep `getProfileID` as `getProfileIDLegacy` and use it as a fallback if `getProfileSub` fails because of permission scope. In this way, it's not a breaking change because one that has only a deprecated permissions such as `r_liteprofile` will still be able to hit `v2/me` this logic is encapsulated in the new function `getProfileURN`, that resolves the user identifier and returns it formatted as a URN --------- Co-authored-by: Gabriel F Cipriano <gabriel.cipriano@farme.com.br>
Thanks for this, all working as expected now! |
Got another error with this recently:
Havent't changed anything since it was previously working |
:pain: did they change their api again? PS: I fixed the issue in the error message (the nil error |
Is there a way to have the action step still pass after the announce fails? I'd love to continue to test this out on my project but don't want the whole action to fail if this fails as it's not really overly important, the tool is still released on homebrew by this stage |
currently it isn't, but maybe we could add a |
What happened?
Trying to use the LinkedIn announce feature, I've supplied my access token in my workflow and passed it to the Github Action. The releases all pass, then the announce fails with the error in the title. Am I doing something wrong, or is there any further setup that needs to be done on my side for this to work? The docs for this were pretty lacking
How can we reproduce this?
https://github.com/stefanlogue/meteor
My public repo that reproduces the issue currently
goreleaser version
GoReleaser Check
Search
Supporter
Code of Conduct
Additional context
No response
The text was updated successfully, but these errors were encountered: