Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing to winget without archiving #4494

Closed
2 of 3 tasks
vedantmgoyal9 opened this issue Dec 21, 2023 · 1 comment · Fixed by #4498
Closed
2 of 3 tasks

Publishing to winget without archiving #4494

vedantmgoyal9 opened this issue Dec 21, 2023 · 1 comment · Fixed by #4498
Assignees
@caarlos0
Labels
enhancement New feature or request
Milestone
v1.23.0

Comments

@vedantmgoyal9
Copy link
Contributor

vedantmgoyal9 commented Dec 21, 2023 •
edited

Is your feature request related to a problem? Please describe.

Winget support in GoReleaser fails when archive: [ format:binary] is set.

Describe the solution you'd like

Instead, GoReleaser should create manifests, with a direct URL to the binary, replacing InstallerType: zip with InstallerType: portable and omitting NestedInstaller fields.

Describe alternatives you've considered

N/A

Search

  • I did search for other open and closed issues before opening this

Supporter

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response
@vedantmgoyal9 vedantmgoyal9 added enhancement New feature or request triage Issue pending triage by one of the maintainers labels Dec 21, 2023
caarlos0 added a commit that referenced this issue Dec 21, 2023
@caarlos0
feat(winget): support installing .exe directly
39b1177 
closes #4494
caarlos0 added a commit that referenced this issue Dec 21, 2023
@caarlos0
feat(winget): support installing .exe directly
ddfe119 
closes #4494
@caarlos0 caarlos0 mentioned this issue Dec 21, 2023
Merged
@caarlos0
Copy link
Member

can you check #4498?

@caarlos0 caarlos0 added this to the v1.23.0 milestone Dec 21, 2023
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Dec 21, 2023
caarlos0 added a commit that referenced this issue Dec 26, 2023
@caarlos0 @vedantmgoyal9
feat(winget): support installing .exe directly (#4498)
27f0e33 
closes #4494

---------

Co-authored-by: Vedant <83997633+vedantmgoyal2009@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging a pull request may close this issue.

feat(winget): support installing .exe directly goreleaser/goreleaser
2 participants
@caarlos0 @vedantmgoyal9