Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming inconsistency betweeen folder for Homebrew and directory for AUR #4732

Closed
3 of 4 tasks
bartekpacia opened this issue Mar 29, 2024 · 1 comment · Fixed by #4737
Closed
3 of 4 tasks

Naming inconsistency betweeen folder for Homebrew and directory for AUR #4732

bartekpacia opened this issue Mar 29, 2024 · 1 comment · Fixed by #4737
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented Mar 29, 2024

Description

For AUR (docs):

# .goreleaser.yaml
aurs:
  -
    name: foo-bin
    directory: foo-bin

Results in:

$ tree -a .
.
├── foo-bin
│   ├── .SRCINFO
│   └── PKGBUILD

For Homebrew (docs):

# .goreleaser.yaml
brews:
  -
    name: foo

    # Folder inside the repository to put the formula.
    folder: Formula

Results in:

$ tree -a .
.
├── Formula
│   ├── foo.rb

Proposal

Would be nice (for consistency) to settle either on directory or folder.

goreleaser version

output
$ goreleaser --version
  ____       ____      _
 / ___| ___ |  _ \ ___| | ___  __ _ ___  ___ _ __
| |  _ / _ \| |_) / _ \ |/ _ \/ _` / __|/ _ \ '__|
| |_| | (_) |  _ <  __/ |  __/ (_| \__ \  __/ |
 \____|\___/|_| \_\___|_|\___|\__,_|___/\___|_|
goreleaser: Deliver Go Binaries as fast and easily as possible
https://goreleaser.com

GitVersion:    v1.24.1-0.20240308165802-85f213c9da5e
GitCommit:     unknown
GitTreeState:  unknown
BuildDate:     unknown
BuiltBy:       unknown
GoVersion:     go1.22.1
Compiler:      gc
ModuleSum:     h1:DvK8/lL/M513VkviSCuNSZXImqyP7Df+AjpdyTqbejU=
Platform:      darwin/arm64

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this

Supporter

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@bartekpacia bartekpacia added bug Something isn't working triage Issue pending triage by one of the maintainers labels Mar 29, 2024
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Mar 29, 2024
@caarlos0
Copy link
Member

you're right, just opened #4737 fixing this!

thanks for the thoughtful issue 🙏

@caarlos0 caarlos0 added this to the v1.25.0 milestone Mar 30, 2024
caarlos0 added a commit that referenced this issue Apr 1, 2024
It was a mess of "folder" x "directory", so changed it all to
"directory".

Closes #4732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants