Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Homebrew to download releases from private GitHub repo #507

Closed
loa opened this issue Jan 17, 2018 · 7 comments · Fixed by #509
Closed

Enable Homebrew to download releases from private GitHub repo #507

loa opened this issue Jan 17, 2018 · 7 comments · Fixed by #509
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@loa
Copy link

loa commented Jan 17, 2018

We plan using goreleaser + homebrew for handling new internal tools. We will be using a private homebrew tap and private repos for the tools on GitHub. Homebrew added the functionality to download release assets from private GitHub repos last year Homebrew 1.2.0.

Can we add an option to the brew provider to be able to support this?

Example options:

brew:
   # narrow example
  private_github_repo: true
  
  # generic but verbose
  download_strategy: GitHubPrivateRepositoryReleaseDownloadStrategy

What is needed in the generated Formulas to be able to download releases from private GitHub repositories:

class Tinkernetes < Formula
-   url "https://github.com/loa/foobar/releases/download/0.1.0/foobar_0.1.0_darwin_amd64.tar.gz"
+   url "https://github.com/loa/foobar/releases/download/0.1.0/foobar_0.1.0_darwin_amd64.tar.gz", :using => GitHubPrivateRepositoryReleaseDownloadStrategy
end

References:

@caarlos0 caarlos0 added this to the v1.0.0 milestone Jan 17, 2018
@caarlos0
Copy link
Member

I like the more verbose because it won't require changes if the user wants other strategies...

@caarlos0
Copy link
Member

/remind me this in 9 hours

@reminders reminders bot added the reminder label Jan 17, 2018
@reminders
Copy link

reminders bot commented Jan 17, 2018

@caarlos0 set a reminder for Today at 8:43 PM

@reminders reminders bot removed the reminder label Jan 17, 2018
@reminders
Copy link

reminders bot commented Jan 17, 2018

👋 @caarlos0, this

caarlos0 added a commit that referenced this issue Jan 17, 2018
@caarlos0 caarlos0 self-assigned this Jan 17, 2018
caarlos0 added a commit that referenced this issue Jan 17, 2018
caarlos0 added a commit that referenced this issue Jan 17, 2018
@loa
Copy link
Author

loa commented Jan 18, 2018

Light speed! Thanks @caarlos0

@caarlos0
Copy link
Member

np @loa :)

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants