Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew code doesn't acknowledge format_overrides #720

Closed
tombh opened this issue Jul 11, 2018 · 2 comments · Fixed by #721
Closed

Homebrew code doesn't acknowledge format_overrides #720

tombh opened this issue Jul 11, 2018 · 2 comments · Fixed by #721
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tombh
Copy link

tombh commented Jul 11, 2018

Describe the bug
When using a main format of binary and a format override of zip the Homebrew code doesn't acknowledge override for darwin.

To Reproduce
Specify the default format as binary and specify the format override for darwin as zip.

project_name: browsh
builds:
  - main: .
    binary: browsh
    goos:
      - windows
      - darwin
      - linux
      - freebsd
    goarch:
      - amd64
      - arm
    ldflags: -s -w
    hooks:
      post: ../contrib/upx_compress_binary.sh

archive:
  format: binary
  format_overrides:
    - goos: darwin
      format: zip

nfpm:
  vendor: Browsh
  homepage: https://brow.sh
  maintainer: Thomas Buckley-Houston <tom@tombh.co.uk>
  description: A fully interactive, realtime and modern browser rendered to TTY
  license: GPL v3
  formats:
    - deb
    - rpm

  dependencies:
    - firefox

release:
  disable: true

brew:
  name: browsh

  # Reporitory to push the tap to.
  github:
    owner: browsh-org
    name: homebrew-browsh

  commit_author:
    name: Goreleaser Bot care of Travis CI
    email: builds@travis-ci.com

  homepage: "https://www.brow.sh"

  description: "The modern, text-based browser"

  dependencies:
    - firefox

Expected behavior
Homebrew code should run without this response:

• CREATING HOMEBREW FORMULA
      • skipped                   reason=archive format is binary

Using curl -sL http://git.io/goreleaser | bash

@caarlos0 caarlos0 added the bug Something isn't working label Jul 11, 2018
caarlos0 added a commit that referenced this issue Jul 11, 2018
@caarlos0 caarlos0 self-assigned this Jul 11, 2018
@caarlos0 caarlos0 added this to the v1.0.0 milestone Jul 11, 2018
@caarlos0
Copy link
Member

Thanks! Opened #721

tombh added a commit to browsh-org/browsh that referenced this issue Jul 11, 2018
This is the wrong way round, it should default to binary as that's what
most of the OS's are and just set the zip override for `darwin`.

Watch this issue for updates:
goreleaser/goreleaser#720
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants