Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHE with self signed cert #916

Closed
vshiva opened this issue Jan 9, 2019 · 2 comments
Closed

Support GHE with self signed cert #916

vshiva opened this issue Jan 9, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@vshiva
Copy link

vshiva commented Jan 9, 2019

Is your feature request related to a problem? Please describe.
Need support to specify ca-cert that for the github urls hosted by the company.

Describe the solution you'd like
allow ca cert location or ca cert data or simply say insecure-skip-tls-verify

for example

github_urls:
  api: https://git.company.com/api/v3/
  upload: https://git.company.com/api/uploads/
  download: https://git.company.com/
  insecure-skip-tls-verify: true
  certificate-authority-data: <in-line ca cert data that client can use>
  certificate-authority: <file-path of ca cert that http client can use>

however only one of insecure-skip-tls-verify or certificate-authority-data or certificate-authority will take precedence

Describe alternatives you've considered
None.

Additional context
go-github allows specifying a http.Client. If not specified, uses the default client. One option is to allow the user to specify ca-cert that goreleaser can use to create a http.Client and initialize the github.Client with that

@caarlos0 caarlos0 added the enhancement New feature or request label Jan 9, 2019
@caarlos0 caarlos0 added this to the v1.0.0 milestone Jan 17, 2019
@caarlos0
Copy link
Member

for now I added the skip verify option, should work in your case...

will close this for now, thanks!

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants