Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple sign #1088

Merged
merged 1 commit into from Jul 21, 2019
Merged

feat: multiple sign #1088

merged 1 commit into from Jul 21, 2019

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 20, 2019

add support to multiple sign instructions.

closes #1087

cc/ @joemiller @magiconair

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov-io
Copy link

codecov-io commented Jul 20, 2019

Codecov Report

Merging #1088 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
+ Coverage   84.06%   84.13%   +0.07%     
==========================================
  Files          57       57              
  Lines        2931     2944      +13     
==========================================
+ Hits         2464     2477      +13     
  Misses        390      390              
  Partials       77       77
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/sign/sign.go 94.8% <100%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636f607...d71442c. Read the comment docs.

@caarlos0 caarlos0 merged commit 5c16574 into master Jul 21, 2019
@caarlos0 caarlos0 deleted the multiple-sign branch July 21, 2019 21:46
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support multiple signing actions
2 participants