Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve build #2475

Merged
merged 2 commits into from Sep 11, 2021
Merged

refactor: improve build #2475

merged 2 commits into from Sep 11, 2021

Conversation

caarlos0
Copy link
Member

prepare the build api for future features:

  • move matrix gen to another pkg
  • merge target stuff with build opts
  • renamed builds.lang to builds.builder

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2021
@vercel
Copy link

vercel bot commented Sep 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/3tyUBGSM3HCtCGA7RoLBFM5FsJ1v
✅ Preview: https://goreleaser-git-build-goreleaser.vercel.app

@vercel vercel bot temporarily deployed to Preview September 11, 2021 03:47 Inactive
@caarlos0 caarlos0 added this to In progress in Board Sep 11, 2021
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #2475 (33ed61f) into master (8241a23) will decrease coverage by 0.29%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2475      +/-   ##
==========================================
- Coverage   84.49%   84.19%   -0.30%     
==========================================
  Files          88       88              
  Lines        6340     6335       -5     
==========================================
- Hits         5357     5334      -23     
- Misses        827      840      +13     
- Partials      156      161       +5     
Impacted Files Coverage Δ
pkg/config/config.go 90.72% <ø> (ø)
internal/builders/buildtarget/targets.go 94.69% <50.00%> (ø)
internal/pipe/build/build.go 88.77% <86.95%> (-9.53%) ⬇️
internal/builders/golang/build.go 92.14% <100.00%> (+0.51%) ⬆️
internal/tmpl/tmpl.go 95.83% <100.00%> (+0.07%) ⬆️
pkg/build/build.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8241a23...33ed61f. Read the comment docs.

@caarlos0 caarlos0 merged commit d77f862 into master Sep 11, 2021
Board automation moved this from In progress to Done Sep 11, 2021
@caarlos0 caarlos0 deleted the build branch September 11, 2021 16:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
Board
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant