Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split go mod into 2 pipes #2502

Merged
merged 1 commit into from Sep 23, 2021
Merged

refactor: split go mod into 2 pipes #2502

merged 1 commit into from Sep 23, 2021

Conversation

caarlos0
Copy link
Member

split the gomod pipe into 2:

  • one just loads the go module information (aka set ctx.ModulePath)
  • the other, if enabled, proxies the modules

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Sep 23, 2021
@caarlos0 caarlos0 self-assigned this Sep 23, 2021
@caarlos0 caarlos0 added this to In progress in Board via automation Sep 23, 2021
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 23, 2021
@vercel
Copy link

vercel bot commented Sep 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/EC3Hqreux41Gno94njVPanokPLks
✅ Preview: https://goreleaser-git-gomod-goreleaser.vercel.app

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #2502 (272e7e8) into master (28ef87b) will decrease coverage by 0.01%.
The diff coverage is 73.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
- Coverage   83.40%   83.39%   -0.02%     
==========================================
  Files          92       93       +1     
  Lines        6467     6462       -5     
==========================================
- Hits         5394     5389       -5     
  Misses        916      916              
  Partials      157      157              
Impacted Files Coverage Δ
internal/pipe/gomod/gomod.go 100.00% <ø> (+21.55%) ⬆️
internal/pipe/gomod/gomod proxy.go 73.40% <73.40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ef87b...272e7e8. Read the comment docs.

@caarlos0 caarlos0 merged commit f7c865c into master Sep 23, 2021
Board automation moved this from In progress to Done Sep 23, 2021
@caarlos0 caarlos0 deleted the gomod branch September 23, 2021 01:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
No open projects
Board
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant