fix: bug in handling gitlab-ci style urls #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
|
@drewstinnett is attempting to deploy a commit to the goreleaser Team on Vercel. A member of the Team first needs to authorize it. |
caarlos0
approved these changes
Sep 28, 2021
|
Thanks! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix parsing of the git URL format that is used by gitlab-ci runners, for example:
The URL style above works correctly in v0.179.0, but not v0.180.0, I believe because of the following PR:
https://github.com/goreleaser/goreleaser/pull/2474/files
Thanks, for the consideration, and for the awesome project in general!