fix(brew): Remove deprecated bottle :unneeded
#2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
Fixes this warning from Homebrew: `Warning: Calling bottle :unneeded is deprecated! There is no replacement.`
mcornick
changed the title
bottle :unneeded from brewsbottle :unneeded
|
I'm chasing down that extra newline that was added - will update the PR with a fix. |
auto-merge was automatically disabled
October 19, 2021 18:47
Head branch was pushed to by a user without write access
caarlos0
approved these changes
Oct 19, 2021
auto-merge was automatically disabled
October 19, 2021 19:01
Head branch was pushed to by a user without write access
|
Thanks for your patience - I think I've got the formula template fixed up properly now. (Newlines in go templates always seem to bite me...) |
you and me both eheh |
Codecov Report
@@ Coverage Diff @@
## master #2591 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 98 98
Lines 7207 7207
=======================================
Hits 5973 5973
Misses 1043 1043
Partials 191 191 Continue to review full report at Codecov.
|
|
thanks! |
3 tasks
jabley
added a commit
to jabley/kubeval
that referenced
this pull request
Oct 20, 2021
Use the next-gen language images as per https://circleci.com/docs/2.0/circleci-images/ Change proposed to create a new build which will pick up goreleaser/goreleaser#2591
This was referenced Oct 20, 2021
jason-fugue
pushed a commit
to fugue/regula
that referenced
this pull request
Nov 9, 2021
`brew install` or `brew upgrade` for `regula` currently shows the following: ```sh Warning: Calling bottle :unneeded is deprecated! There is no replacement. Please report this issue to the fugue/regula tap (not Homebrew/brew or Homebrew/core): /usr/local/Homebrew/Library/Taps/fugue/homebrew-regula/Formula/regula.rb:9 ``` The generation is fixed in goreleaser/goreleaser#2591 and available with GoReleaser v0.183.0. Signed-off-by: Timofey Ilinykh <ilinytim@gmail.com>
7 tasks
This was referenced Nov 17, 2021
rothgar
added a commit
to rothgar/awsls
that referenced
this pull request
Dec 16, 2021
I believe this includes a newer version of the homebrew formula which fixes jckuester#45 via goreleaser/goreleaser#2591
rothgar
added a commit
to rothgar/kubecolor
that referenced
this pull request
Dec 16, 2021
Updates the homebrew formula to remove bottle. fixes hidetatz#81 via goreleaser/goreleaser#2591
jckuester
pushed a commit
to jckuester/awsls
that referenced
this pull request
Feb 9, 2022
I believe this includes a newer version of the homebrew formula which fixes #45 via goreleaser/goreleaser#2591
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
bottle :unneededfrom brew formula generated by goreleaser.bottle :unneedednow provokes a warning from Homebrew:Warning: Calling bottle :unneeded is deprecated! There is no replacement.Homebrew apparently deprecated
bottle :unneededin Homebrew/brew@f65d525